-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
gh-72249: Correct wording of GH-101910 blurb #138468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
approved these changes
Sep 3, 2025
serhiy-storchaka
approved these changes
Sep 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
|
Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 3, 2025
…8468) This incidentally corrects a reST issue reported by Daniel Nylander from the Swedish translation. (cherry picked from commit 007bc5f) Co-authored-by: Zachary Ware <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 3, 2025
…8468) This incidentally corrects a reST issue reported by Daniel Nylander from the Swedish translation. (cherry picked from commit 007bc5f) Co-authored-by: Zachary Ware <[email protected]>
|
GH-138470 is a backport of this pull request to the 3.14 branch. |
|
GH-138471 is a backport of this pull request to the 3.13 branch. |
hugovk
pushed a commit
that referenced
this pull request
Sep 3, 2025
) Co-authored-by: Zachary Ware <[email protected]>
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…onGH-138468) (python#138470) Co-authored-by: Zachary Ware <[email protected]>
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
…8468) This incidentally corrects a reST issue reported by Daniel Nylander from the Swedish translation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to GH-138370, which I believe addresses a symptom rather than the underlying issue that the original message contains a thinko :)
This change is a more thorough rewording than my suggestion on the other PR.